Moved RuntimeError from initialisation of Dummy ctype to where the va… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riable is written. Reading is allowed for easier debugging.
|
Can you provide an example use case which shows the easier debugging? |
| @@ -56,7 +56,8 @@ class Dummy(Array): | |||
| _length_ = 1 | |||
| _type_ = c_ubyte | |||
| def __init__(self, *args): | |||
| raise RuntimeError('Dummy ctypes object cannot be created or written') | |||
| pass # moved RuntimeError to where the variable is written | |||
| # raise RuntimeError('Dummy ctypes object cannot be created or written') | |||
There was a problem hiding this comment.
Please remove this commented line.
| @@ -56,7 +56,8 @@ class Dummy(Array): | |||
| _length_ = 1 | |||
| _type_ = c_ubyte | |||
| def __init__(self, *args): | |||
| raise RuntimeError('Dummy ctypes object cannot be created or written') | |||
| pass # moved RuntimeError to where the variable is written | |||
There was a problem hiding this comment.
This comment does not belong in the code, it is in the GIT history. This whole __init__ can now be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved RuntimeError from initialisation of Dummy ctype to where the variable is written. Reading is allowed for easier debugging.